Set up libc team to give members bors perms #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Clippy warnings are fixed in #453. |
Member
|
Can you rebase on top of master? |
Member
|
These changes look good! I think if you remove |
Member
Author
|
Okay, removed in bf80d7b :) |
Member
Member
Author
|
Ouch! Should I remove them entirely? |
Member
|
Yeah. |
Member
Author
|
It's now green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, we now need to use bors on libc as the number of GHA jobs is large (rust-lang/libc#1918 (comment)). And as suggested in #444, I set up libc team to give us bors permission.
I'm not sure, but I think it's worth adding the GitHub team as well for the repository perms.
Closes #444
cc @joshtriplett and @pietroalbini