Grant rust-analyzer team perf/crater permissions
#2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-a already has bors r+ permissions, it makes sense to grant r-a perf and crater permissions for perf experiments and such.
jieyouxu
added
needs-team-repo-admin-review
Dry-run check results |
lnicola
reviewed
Oct 24, 2025
Member
lnicola
left a comment
lnicola
left a comment
There was a problem hiding this comment.
This is fine, but we're unlikely to be able to use it right now for rust-analyzer because of the way it's (not) wired up.
lnicola
approved these changes
Oct 24, 2025
Member
|
I still have wiring up RA into rustc-perf in my backlog, I plan to work on it once we finish the move to the multi-collector setup, because that is actually a blocker for running non-default (such as RA) benchmarks anyway. |
Member
Author
|
(FWIW, this is also useful for r-a members even if it's not for r-a directly per se, but also for compiler-side changes on r-l/r) |
marcoieni
approved these changes
Oct 27, 2025
jieyouxu
added
needs-infra-admin-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-analyzer team already has bors r+ permissions, it makes sense to grant r-a perf and crater permissions for perf experiments and such as well.
Discussed in #t-infra > r-a team has bors.rust.review = true but no other perms?.
FYI @rust-lang/rust-analyzer