Skip to content

Create smol-str marker team for rust-analyzer/smol_str #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create smol-str marker team for rust-analyzer/smol_str #2036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions repos/rust-analyzer/smol_str.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ bots = []

[access.teams]
rust-analyzer = "write"
smol-str = "write"
12 changes: 12 additions & 0 deletions teams/smol-str.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name = "smol-str"
kind = "marker-team"
Comment on lines +1 to +2
Copy link
Member Author

@jieyouxu jieyouxu Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: ah, @ehuss had the reasonable concern where we probably shouldn't be using marker teams for actual permissions (i.e. this should be a proper subteam).

If you are onboard with making expect-test and smol-str proper subteams of r-a, I can also do that @Veykril.

Copy link
Contributor

@ehuss ehuss Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I would prefer to avoid using marker teams for anything like this. I think it's fine to create a real team. The charter can be something as simple as "Responsible for maintaining and updating the smol-str crate."

Copy link
Member Author

@jieyouxu jieyouxu Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll change this to charter a proper r-a smol-str subteam, and if Lukas is in favor, we can recharter the expect-test marker team into a proper r-a subteam as well.

EDIT: holding off in case r-a wants a -crates team #2036 (comment)


[people]
leads = ["alexheretic"]
members = [
"alexheretic",
]
alumni = []

[[github]]
orgs = ["rust-analyzer"]