Skip to content

Conversation

@madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Oct 22, 2025

Motivation: To make Jiahao show up on the website.

This also removes the [access.individuals] key for cc-rs as part of #1476.

CC @rust-lang/crate-maintainers, this would add @NobodyXu and myself to your team. I would limit my use of these rights to contributions to cc-rs (which admittedly has been very limited lately), I suspect @NobodyXu would do the same.

An alternative would be to create a separate team @rust-lang/cc, I'd be fine with either.

To remove the `[access.individuals]` key in `cc-rs`, and to make
Jiahao show up on the website.
@github-actions
Copy link

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Team Diffs:
    📝 Editing team 'rust-lang/all':
      Adding member 'NobodyXu' with member role
    📝 Editing team 'rust-lang/crate-maintainers':
      Adding member 'NobodyXu' with member role
      Adding member 'madsmtm' with member role
    💻 Repo Diffs:
    📝 Editing repo 'rust-analyzer/smol_str':
      Permission Changes:
        Removing user 'alexheretic''s write permission 
    📝 Editing repo 'rust-lang/cc-rs':
      Permission Changes:
        Removing user 'madsmtm''s write permission 
        Removing user 'NobodyXu''s write permission 

@madsmtm
Copy link
Contributor Author

madsmtm commented Oct 22, 2025

📝 Editing repo 'rust-analyzer/smol_str':
  Permission Changes:
    Removing user 'alexheretic''s write permission 

That looks wrong? CC @alexheretic, it looks like you're not part of the rust-analyzer team?

@NobodyXu
Copy link
Contributor

Thanks Mads!

I'll also most likely contributing to cc-ras, very occasionally if jobserver has a bug impacting cc-rs or cc needs a feature from it, I might post a PR there and asks for others to review.

@jieyouxu jieyouxu added needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. needs-team-lead-review This change requires a team/WG/PG lead to review. S-waiting-on-team Status: waiting on team labels Oct 22, 2025
@alexheretic
Copy link

alexheretic commented Oct 22, 2025

📝 Editing repo 'rust-analyzer/smol_str':
  Permission Changes:
    Removing user 'alexheretic''s write permission 

That looks wrong? CC @alexheretic, it looks like you're not part of the rust-analyzer team?

I've just started to collaborate on smol_str crate, so to that extent maybe I should be?

@ChrisDenton
Copy link
Member

I think this is ultimately on @Amanieu (as libs team lead) to approve but I this should be fine since they both are already maintaining a libs crate. I don't think we need a special group just for cc-rs.

@jieyouxu jieyouxu added S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. and removed needs-team-lead-review This change requires a team/WG/PG lead to review. S-waiting-on-team Status: waiting on team labels Oct 23, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by parent team co-lead.

@jieyouxu jieyouxu added this pull request to the merge queue Oct 23, 2025
Merged via the queue into rust-lang:master with commit 96a503c Oct 23, 2025
3 checks passed
@madsmtm madsmtm deleted the cc-crate-maintainers branch October 23, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants