Give stable-mir r+ access for their code #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
cc @rust-lang/project-stable-mir |
|
This is great, since oli is absent we were lacking in "r" power 😁 |
davidtwco
approved these changes
Nov 8, 2023
Mark-Simulacrum
approved these changes
Nov 10, 2023
celinval
added a commit
to celinval/rust-team-dev
that referenced
this pull request
Nov 16, 2023
These members were granted r+ permission here: rust-lang#1110 However, trying to assign a PR to them will trigger a rustbot error: > Failed to set assignee to celinval: invalid assignee >> Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned. I think the problem is that we also need to add the team as maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to give the stable-mir project the ability to r+ stable mir PRs in the compiler since that area is under their purview.
r? @davidtwco