Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify empty match arm format #147

Closed
wants to merge 1 commit into from
Closed

Conversation

varkor
Copy link
Member

@varkor varkor commented Jan 8, 2020

Prefer pattern => {} over pattern => ().

Fixes #146.

Prefer `pattern => {}` over `pattern => ()`.
@calebcartwright
Copy link
Member

I'm really surprised there hasn't been more feedback on this one way or the other. I'm going to continue to hold off on merging because doing so would for the first time put us in a tricky situation where rustfmt would either have to deliberately introduce breaking changes or would conflict with/fail to follow the style guide.

If we get an opportunity to push through some breaking changes (and there's a few that desperately need to be made) will be sure that this is accounted for, likely with an accompanying config option in rustfmt that allows users to use whichever they want

@calebcartwright
Copy link
Member

Closing as the style guide no longer lives in this repo (it's in r-l/rust), and we'll use #146 as the tracking issue to discuss style plans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify style of empty match arms
2 participants