Implement automatic verification for ARM/AArch64 intrinsics#626
Merged
alexcrichton merged 1 commit intorust-lang:masterfrom Dec 20, 2018
Merged
Implement automatic verification for ARM/AArch64 intrinsics#626alexcrichton merged 1 commit intorust-lang:masterfrom
alexcrichton merged 1 commit intorust-lang:masterfrom
Conversation
This commit implements automatic verification of implement ARM/AArch64 intrinsics. Or it's at least a start! This downloads a snapshot of ARM's [online documentation][docs] and implements necessary logic to parse that and use it to verify all the intrinsics. Almost everything checked out A-OK but a few minor tweaks were needed to the neon intrinsics and the crc ones needed some renaming. [docs]: https://developer.arm.com/technologies/neon/intrinsics
alexcrichton
force-pushed
the
verify-arm
branch
from
dc9d46b to
422098f
Compare
Member
Author
|
All green! I'm gonna go ahead and merge this and use it to update the NEON intrinsic listing |
Member
Author
|
cc @myfreeweb for the crc intrinsic naming changes on AArch64 |
Contributor
|
hm, the ones in |
Contributor
now they do AFAICT, or which
|
Contributor
|
Not the CRC ones, the NEON ones, visible in the diff here on github: e.g. |
Member
Author
|
For whatever reason ARM seems to specify |
Contributor
|
But those do not have underscores in the intrinsics guide, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements automatic verification of implement ARM/AArch64
intrinsics. Or it's at least a start! This downloads a snapshot of ARM's
online documentation and implements necessary logic to parse
that and use it to verify all the intrinsics. Almost everything
checked out A-OK but a few minor tweaks were needed to the neon
intrinsics and the crc ones needed some renaming.