Conversation
|
r? @sayantn rustbot has assigned @sayantn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
The CI failure looks unrelated, probably will need some other fix. |
|
the tests are failing because the fix in rust-lang/rust#154043 didn't yet propagate to this repo - it requires a sync job |
|
Yes but the sync job is blocked on this PR :) And also on a hexagon libc issue, that needs to be resolved in the main repo first. So, we're blocked for now. |
😕 so does this mean we would need infra admins to step in and perform a manual sync? |
|
I've just cherry-picked the commit here onto the sync, that should work if not for the hexagon build issue. So we'll just have to wait a bit. |
|
I mentioned in the libc discussion but you should probably drop the Hexagon job for now if it's blocking things. T3 targets are absolutely not consistently tested across rust-lang (nor should they be) so if you've accepted a CI job testing any of them in this repo, you need to be ready to do that. Or at the very least, mark it Looks like the nvptx job is the one failing though? |
See rust-lang/josh-sync#40.