Conversation
|
@adamgemmell (or someone else from arm), could you give the changes to |
|
The JSON looks good to me. This intrinsic isn't part of Neon but it's fine for the JSON to say that to avoid having to edit some of stdarch's tests. As was pointed out on the original rust PR the link to our documentation 404s, but I'll see if we can get this added to that page. |
|
@rfcbot fcp merge lang (Doing the lang-side of the FCP from rust-lang/rust#147555; will check the lang boxes already checked there.) |
|
Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
cc @RalfJung |
|
@rfcbot reviewed |
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. |
tgross35
left a comment
There was a problem hiding this comment.
LGTM but still waiting on FCP at rust-lang/rust#147555 (comment) to complete.
|
The other FCP is over as well. |
implementation: #1938
tracking issue: rust-lang/rust#147555
I think we should stabilize this intrinsic. The
jsconvfeature itself has been stable since1.60.0. The intrinsic works as expected in ruffle, see ruffle-rs/ruffle#22138 (comment).API surface
The
stdarch_aarch64_jscvtfeature contains one function: