Fix generated Neon simd_test features. #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rustbot has picked a reviewer for you, use r? to override) |
jacobbramley
force-pushed
the
dev/neon-tgt-ft
branch
from
64ef5ac
to
5af8e01
Compare
|
Hmm... |
|
As @Nugine said, just remove the extra space in this PR. |
"arm" and "aarch64" support different sets of `target_feature` and `simd_test` arguments, and for "arm", the set of features that can be dynamically detected is different again. Restructure the generator code to allow this to be expressed accurately (in future patches). This implementation preserves the way that target features are specified for shared intrinsics, because this has an impact on the generated documentation. In particular, rustdoc cannot look inside `cfg_attr(target_arch = ...)` tests, so we use unconditional `target_feature` attributes where possible.
The tests can run if and only if the target_features for the corresponding intrinsics are detected at run-time, so make sure that the tests have an appropriate `simd_test()`. This fixes some failures due to tests running when they shouldn't. For example, some tests would fail on hardware that lacks "fcma".
jacobbramley
force-pushed
the
dev/neon-tgt-ft
branch
from
5af8e01
to
1d47fa7
Compare
|
Done. Sorry about the force-push; the whitespace fix wouldn't apply otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests can run if and only if the target_features for the corresponding intrinsics are detected at run-time, so make sure that the tests have an appropriate
simd_test().This fixes some failures due to tests running when they shouldn't. For example, some tests would fail on hardware that lacks "fcma".
This decouples the feature names in the generator, since "arm" and "arm64" use different names, and for "arm" the dynamic
simd_testfeatures don't match the statictarget_featurenames.There are several changes to the tests, but changes to the generated intrinsics themselves are minimal, and cosmetic.