Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Android NDK script to r25b #1337

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chriswailes
Copy link
Contributor

Updating the Android NDK in accordance with new platform support policy.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

@chriswailes
Copy link
Contributor Author

This is related to rust-lang/rust#102332

@Amanieu
Copy link
Member

Amanieu commented Sep 29, 2022

+ mv android-ndk-r25b-linux /android/ndk-x86_64
mv: cannot stat 'android-ndk-r25b-linux': No such file or directory

Perhaps the path within the zip is incorrect?

@chriswailes
Copy link
Contributor Author

Perhaps the path within the zip is incorrect?

Sure was. Needed to drop the -linux suffix.

@Amanieu
Copy link
Member

Amanieu commented Sep 29, 2022

bench_black_box is now stable, you need to remove it from the unstable feature list.

@chriswailes chriswailes force-pushed the ndk-update branch 4 times, most recently from ffd6c4d to 35d5783 Compare October 3, 2022 22:57
Updating the Android NDK in accordance with new platform support policy.
@bors
Copy link
Contributor

bors commented Oct 25, 2022

☔ The latest upstream changes (presumably b585b64) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants