Fix avx512f build on x86-32; fix avx512gfni test fail #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by multiply overflow when generating test case array.
The failed test cases are:
core_arch::x86::avx512gfni::tests::test_mm256_gf2p8affine_epi64_epi8
core_arch::x86::avx512gfni::tests::test_mm256_gf2p8mul_epi8
core_arch::x86::avx512gfni::tests::test_mm256_mask_gf2p8mul_epi8
core_arch::x86::avx512gfni::tests::test_mm256_maskz_gf2p8mul_epi8
core_arch::x86::avx512gfni::tests::test_mm512_gf2p8affine_epi64_epi8
core_arch::x86::avx512gfni::tests::test_mm512_gf2p8mul_epi8
core_arch::x86::avx512gfni::tests::test_mm512_mask_gf2p8mul_epi8
core_arch::x86::avx512gfni::tests::test_mm512_maskz_gf2p8mul_epi8
core_arch::x86::avx512gfni::tests::test_mm_gf2p8affine_epi64_epi8
core_arch::x86::avx512gfni::tests::test_mm_gf2p8mul_epi8
core_arch::x86::avx512gfni::tests::test_mm_mask_gf2p8mul_epi8
core_arch::x86::avx512gfni::tests::test_mm_maskz_gf2p8mul_epi8
---- core_arch::x86::avx512gfni::tests::test_mm256_gf2p8affine_epi64_epi8 stdout ----
thread 'core_arch::x86::avx512gfni::tests::test_mm256_gf2p8affine_epi64_epi8' panicked at 'attempt to multiply with overflow', crates\core_arch\src\x86\avx512gfni.rs:822:24
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- core_arch::x86::avx512gfni::tests::test_mm256_gf2p8mul_epi8 stdout ----
thread 'core_arch::x86::avx512gfni::tests::test_mm256_gf2p8mul_epi8' panicked at 'attempt to multiply with overflow', crates\core_arch\src\x86\avx512gfni.rs:822:24
---- core_arch::x86::avx512gfni::tests::test_mm256_mask_gf2p8mul_epi8 stdout ----
thread 'core_arch::x86::avx512gfni::tests::test_mm256_mask_gf2p8mul_epi8' panicked at 'attempt to multiply with overflow', crates\core_arch\src\x86\avx512gfni.rs:822:24
---- core_arch::x86::avx512gfni::tests::test_mm256_maskz_gf2p8mul_epi8 stdout ----
thread 'core_arch::x86::avx512gfni::tests::test_mm256_maskz_gf2p8mul_epi8' panicked at 'attempt to multiply with overflow', crates\core_arch\src\x86\avx512gfni.rs:822:24
---- core_arch::x86::avx512gfni::tests::test_mm512_gf2p8affine_epi64_epi8 stdout ----
thread 'core_arch::x86::avx512gfni::tests::test_mm512_gf2p8affine_epi64_epi8' panicked at 'attempt to multiply with overflow', crates\core_arch\src\x86\avx512gfni.rs:822:24
---- core_arch::x86::avx512gfni::tests::test_mm512_gf2p8mul_epi8 stdout ----
thread 'core_arch::x86::avx512gfni::tests::test_mm512_gf2p8mul_epi8' panicked at 'attempt to multiply with overflow', crates\core_arch\src\x86\avx512gfni.rs:822:24
---- core_arch::x86::avx512gfni::tests::test_mm512_mask_gf2p8mul_epi8 stdout ----
thread 'core_arch::x86::avx512gfni::tests::test_mm512_mask_gf2p8mul_epi8' panicked at 'attempt to multiply with overflow', crates\core_arch\src\x86\avx512gfni.rs:822:24
---- core_arch::x86::avx512gfni::tests::test_mm512_maskz_gf2p8mul_epi8 stdout ----
thread 'core_arch::x86::avx512gfni::tests::test_mm512_maskz_gf2p8mul_epi8' panicked at 'attempt to multiply with overflow', crates\core_arch\src\x86\avx512gfni.rs:822:24
---- core_arch::x86::avx512gfni::tests::test_mm_gf2p8affine_epi64_epi8 stdout ----
thread 'core_arch::x86::avx512gfni::tests::test_mm_gf2p8affine_epi64_epi8' panicked at 'attempt to multiply with overflow', crates\core_arch\src\x86\avx512gfni.rs:822:24
---- core_arch::x86::avx512gfni::tests::test_mm_gf2p8mul_epi8 stdout ----
thread 'core_arch::x86::avx512gfni::tests::test_mm_gf2p8mul_epi8' panicked at 'attempt to multiply with overflow', crates\core_arch\src\x86\avx512gfni.rs:822:24
---- core_arch::x86::avx512gfni::tests::test_mm_mask_gf2p8mul_epi8 stdout ----
thread 'core_arch::x86::avx512gfni::tests::test_mm_mask_gf2p8mul_epi8' panicked at 'attempt to multiply with overflow', crates\core_arch\src\x86\avx512gfni.rs:822:24
---- core_arch::x86::avx512gfni::tests::test_mm_maskz_gf2p8mul_epi8 stdout ----
thread 'core_arch::x86::avx512gfni::tests::test_mm_maskz_gf2p8mul_epi8' panicked at 'attempt to multiply with overflow', crates\core_arch\src\x86\avx512gfni.rs:822:24
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes:
Note: after I finished fixes I tested with a CPU that supports avx512gfni. The test failed with:
... the cause of this test failure is a multiplication with overflow in test case generating function. I included fix to this function in this pull request.
Please review with error given by rust-lang/rust#91658 (comment) in case I missed any function (which may cause rollup failure again). After this pull request is merged, I'd update pull request rust-lang/rust#91548 to adapt to latest stdarch submodule change.