Skip to content

Conversation

@Keruspe
Copy link
Contributor

@Keruspe Keruspe commented Aug 14, 2020

This restores backward compatibility

Fixes #93
Fixes #95

This restores backward compatibility

Fixes rust-lang#93
Fixes rust-lang#95

Signed-off-by: Marc-Antoine Perennou <[email protected]>
@baoyachi
Copy link

How can this kind of mistake be avoided with use https://semver.org/ in cargo?

@Keruspe
Copy link
Contributor Author

Keruspe commented Aug 14, 2020

@stjepang Could we get a quickfix 0.3.14?

@Keruspe
Copy link
Contributor Author

Keruspe commented Aug 14, 2020

How can this kind of mistake be avoided with use https://semver.org/ in cargo?

semverver helps avoiding this kind of mistakes I think

@baoyachi
Copy link

Taking this event as an example, an hour has passed since the latest version of the update. Developers around the world have indirectly referenced the library, which has led to the failure of the project to compile normally. This control is not in the hands of developers, but in the authors who rely on the library, and the project control is lost。

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost ghost merged commit 7e20f55 into rust-lang:master Aug 14, 2020
@nevi-me
Copy link

nevi-me commented Aug 14, 2020

@baoyachi semver depends on developer interpretation, so mistakes like this will happen once in a while. The changes that led to this issue seem to have been made around April, so without some external pre-release test from crates that depend on this one, I assume it would have been impossible to discover this issue until the new version was released.

@ghost
Copy link

ghost commented Aug 14, 2020

Published v0.3.14

@ghost
Copy link

ghost commented Aug 14, 2020

Really sorry about this! :( Let me know if this resolves the issue - I'll be online and respond promptly. You can also reach me on Discord if need be.

@nevi-me
Copy link

nevi-me commented Aug 14, 2020

Really sorry about this! :( Let me know if this resolves the issue - I'll be online and respond promptly. You can also reach me on Discord if need be.

No worries, it happens :)

It hasn't resolved the issue, there's now another one.

error[E0599]: no function or associated item named `stream` found for struct `socket2::Type` in the current scope
   --> C:\Users\nevi\.cargo\registry\src\github.com-1ecc6299db9ec823\hyper-0.13.7\src\client\connect\http.rs:559:44
    |
559 |     let socket = Socket::new(domain, Type::stream(), Some(Protocol::tcp()))?;
    |                                            ^^^^^^ function or associated item not found in `socket2::Type`

error[E0599]: no function or associated item named `tcp` found for struct `socket2::Protocol` in the current scope
   --> C:\Users\nevi\.cargo\registry\src\github.com-1ecc6299db9ec823\hyper-0.13.7\src\client\connect\http.rs:559:69
    |
559 |     let socket = Socket::new(domain, Type::stream(), Some(Protocol::tcp()))?;
    |                                                                     ^^^ function or associated item not found in `socket2::Protocol`

@nevi-me
Copy link

nevi-me commented Aug 14, 2020

Would it be safer to instead yank 0.3.13 and 0.3.14, and release the update as 0.4.0 @stjepang ?

@ghost
Copy link

ghost commented Aug 14, 2020

Ugh. Okay I'm going to yank this and postpone a new release until we figure this out.

Thomasdezeeuw added a commit to Thomasdezeeuw/socket2 that referenced this pull request Aug 17, 2020
This was added because it was a breaking change in the v0.3.x API, but
for the v0.4.x API this is no longer needed as the associated constants
would be the preferred way to create Domain.

This reverts commit 7e20f55.
Thomasdezeeuw added a commit that referenced this pull request Aug 17, 2020
This was added because it was a breaking change in the v0.3.x API, but
for the v0.4.x API this is no longer needed as the associated constants
would be the preferred way to create Domain.

This reverts commit 7e20f55.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hyper build error Braking change introduced by minor version 0.3.13

3 participants