-
Notifications
You must be signed in to change notification settings - Fork 278
add back Domain::ipv{4,6} #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This restores backward compatibility Fixes rust-lang#93 Fixes rust-lang#95 Signed-off-by: Marc-Antoine Perennou <[email protected]>
|
How can this kind of mistake be avoided with use https://semver.org/ in |
|
@stjepang Could we get a quickfix 0.3.14? |
semverver helps avoiding this kind of mistakes I think |
|
Taking this event as an example, an hour has passed since the latest version of the update. Developers around the world have indirectly referenced the library, which has led to the failure of the project to compile normally. This control is not in the hands of developers, but in the authors who rely on the library, and the project control is lost。 |
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@baoyachi semver depends on developer interpretation, so mistakes like this will happen once in a while. The changes that led to this issue seem to have been made around April, so without some external pre-release test from crates that depend on this one, I assume it would have been impossible to discover this issue until the new version was released. |
|
Published v0.3.14 |
|
Really sorry about this! :( Let me know if this resolves the issue - I'll be online and respond promptly. You can also reach me on Discord if need be. |
No worries, it happens :) It hasn't resolved the issue, there's now another one. error[E0599]: no function or associated item named `stream` found for struct `socket2::Type` in the current scope
--> C:\Users\nevi\.cargo\registry\src\github.com-1ecc6299db9ec823\hyper-0.13.7\src\client\connect\http.rs:559:44
|
559 | let socket = Socket::new(domain, Type::stream(), Some(Protocol::tcp()))?;
| ^^^^^^ function or associated item not found in `socket2::Type`
error[E0599]: no function or associated item named `tcp` found for struct `socket2::Protocol` in the current scope
--> C:\Users\nevi\.cargo\registry\src\github.com-1ecc6299db9ec823\hyper-0.13.7\src\client\connect\http.rs:559:69
|
559 | let socket = Socket::new(domain, Type::stream(), Some(Protocol::tcp()))?;
| ^^^ function or associated item not found in `socket2::Protocol` |
|
Would it be safer to instead yank 0.3.13 and 0.3.14, and release the update as 0.4.0 @stjepang ? |
|
Ugh. Okay I'm going to yank this and postpone a new release until we figure this out. |
This was added because it was a breaking change in the v0.3.x API, but for the v0.4.x API this is no longer needed as the associated constants would be the preferred way to create Domain. This reverts commit 7e20f55.
This was added because it was a breaking change in the v0.3.x API, but for the v0.4.x API this is no longer needed as the associated constants would be the preferred way to create Domain. This reverts commit 7e20f55.
This restores backward compatibility
Fixes #93
Fixes #95