swap bastion EC2

[MarcoIeni]

based on #595 (comment)

  # aws_route53_record.bastion must be replaced
-/+ resource "aws_route53_record" "bastion" {
      + allow_overwrite                  = (known after apply)
      ~ fqdn                             = "bastion.infra.rust-lang.org" -> (known after apply)
      ~ id                               = "Z237AC8WS9NFCS_bastion.infra.rust-lang.org_A" -> (known after apply)
      - multivalue_answer_routing_policy = false -> null
      ~ name                             = "bastion.infra.rust-lang.org" -> "bastion1.infra.rust-lang.org" # forces replacement
        # (4 unchanged attributes hidden)
    }

  # aws_route53_record.bastion2 must be replaced
-/+ resource "aws_route53_record" "bastion2" {
      + allow_overwrite                  = (known after apply)
      ~ fqdn                             = "bastion2.infra.rust-lang.org" -> (known after apply)
      ~ id                               = "Z237AC8WS9NFCS_bastion2.infra.rust-lang.org_A" -> (known after apply)
      - multivalue_answer_routing_policy = false -> null
      ~ name                             = "bastion2.infra.rust-lang.org" -> "bastion.infra.rust-lang.org" # forces replacement
        # (4 unchanged attributes hidden)
    }

Plan: 2 to add, 0 to change, 2 to destroy.

[jdno]

This is fine for now, but long-term I'd really like to clean up the bastion2 resource name. Especially for the DNS record, I find it a bit confusing that the resource is not named the same as the record. Guess when everything is done, we can relatively easily rename the resources in the Terraform state and files.

[MarcoIeni]

applied, but the old address still points to the old ec2 for me.
Maybe I need to wait for dns propagation