Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from failure to anyhow #76

Merged
merged 3 commits into from
Jun 24, 2024
Merged

migrate from failure to anyhow #76

merged 3 commits into from
Jun 24, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented Dec 19, 2022

I would love to get rid of some failure/anyhow compatibility code in docs.rs, and failure is unmaintained anyways.

@syphar
Copy link
Member Author

syphar commented Dec 20, 2022

btw, the test failures are odd, if feels like these are not related to my change, but I don't know rustwide well enough to be sure.

If the tests need fixing I'll dig into it.

@syphar syphar force-pushed the anyhow branch 3 times, most recently from 734b7c4 to a3b5f05 Compare July 31, 2023 19:21
@syphar
Copy link
Member Author

syphar commented Oct 20, 2023

@pietroalbini only pinging you because I heard you're still the main maintainer?
I'm happy to rework this PR to use more specific error types (for example with thiserror), if that is what you prefer.

My motivation is mostly to get rid of the ugly failure-to-anyhow conversion code in docs.rs.

tests/utils/mod.rs Outdated Show resolved Hide resolved
tests/issue_30.rs Outdated Show resolved Hide resolved
src/crates/git.rs Outdated Show resolved Hide resolved
src/crates/local.rs Outdated Show resolved Hide resolved
src/prepare.rs Outdated Show resolved Hide resolved
src/tools/rustup.rs Outdated Show resolved Hide resolved
src/workspace.rs Outdated Show resolved Hide resolved
@syphar syphar force-pushed the anyhow branch 2 times, most recently from 296c02f to e824856 Compare June 24, 2024 06:50
@syphar syphar merged commit 8c1cec5 into rust-lang:master Jun 24, 2024
5 checks passed
@syphar syphar deleted the anyhow branch June 24, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants