Introduce +TOOLCHAIN syntax for proxies.
#615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the first argument to a proxy is of the form `+TOOLCHAIN`, then this
will be interpreted as the toolchain the user wants. That is,
cargo +nightly build
will be equivalent to
rustup run nightly cargo build
This is purely an ergonomic feature designed to reduce typing for people
who frequently switch toolchains (particularly for testing). It is
inspired by a similar feature in the Python launcher.
**Why `+TOOLCHAIN`?**
The obvious candidate (used by Python) of `-TOOLCHAIN` was a no-go.
The issue is that because toolchains can have arbitrary names, it is
difficult to distinguish between a toolchain and an actual argument to
the proxied program in the general case.
`@TOOLCHAIN` was also considered, as it reads somewhat naturally in
English. However, it turns out that `@` is a meta character in
Powershell, which causes the next word to simply *disappear* from the
command line. Presumably, there is a reason for this.
`+TOOLCHAIN` was tested and found to not need escaping with CMD,
Powershell, bash, and fish.
DanielKeep
force-pushed
the
im-too-lazy-to-type-rustup-run
branch
from
c2c52a6
to
990347e
Compare
|
Cool idea. I'm not sure what I think of the syntax, but your rationale is good. Let's get a build out and see what others think of it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first argument to a proxy is of the form
+TOOLCHAIN, then thiswill be interpreted as the toolchain the user wants. That is,
will be equivalent to
This is purely an ergonomic feature designed to reduce typing for people
who frequently switch toolchains (particularly for testing). It is
inspired by a similar feature in the Python launcher.
Why
+TOOLCHAIN?The obvious candidate (used by Python) of
-TOOLCHAINwas a no-go.The issue is that because toolchains can have arbitrary names, it is
difficult to distinguish between a toolchain and an actual argument to
the proxied program in the general case.
@TOOLCHAINwas also considered, as it reads somewhat naturally inEnglish. However, it turns out that
@is a meta character inPowershell, which causes the next word to simply disappear from the
command line. Presumably, there is a reason for this.
+TOOLCHAINwas tested and found to not need escaping with CMD,Powershell, bash, and fish.