Use the env_proxy crate for proxy environment variable handling #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should've referenced #401, but I wasn't aware of it. env_proxy replicates curl's env var handling (as documented in the man page) faithfully. As for the README, would you prefer a short section by itself, say "Proxy support" (after "Environment variables"?), or a paragraph somewhere else? I can add the commit with the change to this PR. |
|
@inejge This looks awesome. For the README, how about another 'working with' section, 'Working with HTTP proxies', after 'working with custom toolchains'? Can you make it a followup? I want to merge this one right now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crate env_proxy encapsulates the rules for selecting the appropriate proxy server for a target URL according to the contents of the current environment, closely following the convention used by curl. This PR replaces the local (and incomplete) proxy determination function with the one provided by that crate.