Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rustls CA certificate loading #585

Merged
merged 2 commits into from
Jul 15, 2016
Merged

Conversation

inejge
Copy link
Contributor

@inejge inejge commented Jul 15, 2016

As an enhancement to #568, add a basic cross-platform CA certificate loading crate and make the download crate use it when compiled with rustls support.

The CA loader crate has seen preliminary testing on Windows, OS X, and a couple of Linux distros. It loads the system root CAs on all of those, with the caveats that a) on CentOS, the default CA bundle contains a line which is invalid UTF-8; a fix for rustls to be more robust is ready and a PR will be opened presently, b) Windows and OS X don't use any kind of local policy to filter out certificates, so all certs which can be enumerated are trusted, c) *BSDs, Android, and Solaris haven't seen any testing.

The loader crate presently lacks any documentation and its error handling is rudimentary. That is being worked on.

@inejge
Copy link
Contributor Author

inejge commented Jul 15, 2016

The ARM build that failed did so because of an incomplete installation:

curl: (18) transfer closed with 15083604 bytes remaining to read
rustup: command failed: curl -# -C - -f -O https://static.rust-lang.org/dist/2016-05-10/rust-std-nightly-arm-unknown-linux-gnueabihf.tar.gz
rustup: couldn't download 'https://static.rust-lang.org/dist/2016-05-10/rust-std-nightly-arm-unknown-linux-gnueabihf.tar.gz'

@brson brson merged commit fe1cc85 into rust-lang:master Jul 15, 2016
@brson
Copy link
Contributor

brson commented Jul 15, 2016

Totally badass.

@inejge inejge deleted the cacert branch July 18, 2016 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants