Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove toolchain directory if initial toolchain install fails #574

Merged
merged 1 commit into from
Jul 12, 2016

Conversation

brson
Copy link
Contributor

@brson brson commented Jul 12, 2016

If initial toolchain installation fails it leaves behind a directory,
which confuses rustup into thinking it's installed.

Again, I don't have any good way to test this. I think the best thing would be to write a FUSE filesystem, but I could also see using environment variables to mock out rustup's file system functions to return weird errors.

r? @alexcrichton

Related to #275 and #330

If initial toolchain installation fails it leaves behind a directory,
which confuses rustup into thinking it's installed.
@brson brson mentioned this pull request Jul 12, 2016
@alexcrichton alexcrichton merged commit 011f79a into rust-lang:master Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants