Skip to content

fix(cli): Style CLI errors in init mode #4735

Merged
rami3l merged 2 commits intorust-lang:mainfrom
epage:cli-fix
Mar 3, 2026
Merged

fix(cli): Style CLI errors in init mode #4735
rami3l merged 2 commits intorust-lang:mainfrom
epage:cli-fix

Conversation

@epage
Copy link
Contributor

@epage epage commented Mar 2, 2026

By rolling back tracing-subscriber for now

Fixes #4731

Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for you investigation!

It'd probably be better if we just = pin that to the older version and add a comment explaining why, we've done the same in #4708.

Also although it's okay to close the original issue with this, I'm not sure if a new follow-up issue should be made regarding the future development.

Otherwise LGTM!

View changes since this review

@djc
Copy link
Contributor

djc commented Mar 3, 2026

Is there an issue against tracing-subscriber?

@rami3l
Copy link
Member

rami3l commented Mar 3, 2026

Is there an issue against tracing-subscriber?

@djc Yes, the regression seems intentional and for which we have an upstream issue at tokio-rs/tracing#3369.

@rami3l
Copy link
Member

rami3l commented Mar 3, 2026

Update: It seems that UV has been hit by this as well (astral-sh/uv#15843) and what they did was to (at least for the moment being) forget about color codes in such occasions.

@epage
Copy link
Contributor Author

epage commented Mar 3, 2026

I'm not sure if a new follow-up issue should be made regarding the future development.

Yes, I think it makes sense to open an issue for tracking the ability to upgrade tracing-subscriber

One approach I was playing with (but hit a time box so switched to this) is to extract from rustup_mode.rs the clap error handling and reusing it for setup_ode.rs.

@rami3l rami3l added this pull request to the merge queue Mar 3, 2026
Merged via the queue into rust-lang:main with commit 2bccc3f Mar 3, 2026
29 checks passed
@epage epage deleted the cli-fix branch March 3, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI errors show escape codes

3 participants