Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli/common)!: deny installing a host-incompatible toolchain w/o --force-non-host #4028

Merged
merged 5 commits into from
Sep 22, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Sep 22, 2024

Closes #3982, as discussed in #3982 (comment).

@rami3l rami3l added this to the 1.28.0 milestone Sep 22, 2024
@rami3l rami3l requested a review from djc September 22, 2024 07:34
@rami3l rami3l changed the title refactor(cli/common)!: throw an error when installing a toolchain for an incompatible host refactor(cli/common)!: deny installing a toolchain for an incompatible host w/o --force-non-host Sep 22, 2024
@rami3l rami3l changed the title refactor(cli/common)!: deny installing a toolchain for an incompatible host w/o --force-non-host refactor(cli/common)!: deny installing a host-incompatible toolchain w/o --force-non-host Sep 22, 2024
@rami3l rami3l force-pushed the feat/deny-incompat-host branch from aeaeffc to 3b0c072 Compare September 22, 2024 07:56
@rami3l rami3l force-pushed the feat/deny-incompat-host branch from 3b0c072 to 73348d4 Compare September 22, 2024 07:58
@rami3l rami3l added this pull request to the merge queue Sep 22, 2024
Merged via the queue into master with commit 9cf01dd Sep 22, 2024
27 checks passed
@rami3l rami3l deleted the feat/deny-incompat-host branch September 22, 2024 10:10
@rami3l rami3l mentioned this pull request Oct 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide how the --force-non-host flag should evolve
2 participants