fix(manifest): consider possible renames in Component::try_new()
#3991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
commented
Aug 14, 2024
rami3l
force-pushed
the
fix/component-add-remove-with-rename
branch
from
468e944 to
ffecbc6
Compare
djc
approved these changes
Aug 19, 2024
| @@ -498,19 +498,11 @@ impl Component { | |||
| distributable: &DistributableToolchain<'_>, | |||
| fallback_target: Option<&TargetTriple>, | |||
| ) -> Result<Self> { | |||
| let manifest = distributable.get_manifest()?; | |||
There was a problem hiding this comment.
It looks like distributable.components() also contains a call to distributable.get_manifest(), so doing that twice might be kind of wasteful? Is it worth doing that differently?
There was a problem hiding this comment.
@djc For the moment I'd like to keep it that way for readability, as this really isn't a hot function. I agree that the implementation is weird underneath, but as soon as I replace that with an inlined .components() I realized .get_manifest() actually calls .get_manifestation() which belongs to another layer of problems to be solved... Let's keep it this way first?
It definitely requires some refactoring afterwards anyway.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3601. Addresses the following concern:
by @yangby-cryptape in #3166 (comment)