Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loongarch64-unknown-linux-musl support #3921

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Add loongarch64-unknown-linux-musl support #3921

merged 2 commits into from
Jul 5, 2024

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Jul 3, 2024

skip-stable because we're not going to release this for now

- x86_64-linux-android # skip-pr skip-master
- riscv64gc-unknown-linux-gnu # skip-pr skip-master
- loongarch64-unknown-linux-gnu # skip-pr skip-master
- loongarch64-unknown-linux-musl # skip-pr skip-master skip-stable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm so you're saying that the CI should completely ignore this target as for now, if I'm not mistaken?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If I'm not mistaken, rustup is currently only built with stable rustc. The first stable version of loongarch64-linux-musl will be 1.81, when skip-stable will be removed. Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heiher I see. Thanks for the explanation!

Copy link
Member

@rami3l rami3l Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heiher Are we ready for releasing this on stable now?

This should be the right time if possible, since we're releasing v1.28.0 beta very soon:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heiher (a gentle ping...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed the previous notification. I’ll enable the stable build for this target soon. Thanks for your mention.

Copy link
Member

@rami3l rami3l Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heiher Thanks for your approval! I'll place this change directly in #4105 for the sake of convenience :)

@rami3l rami3l added this to the 1.28.0 milestone Jul 4, 2024
@rami3l rami3l requested a review from djc July 5, 2024 03:25
@rami3l rami3l added this pull request to the merge queue Jul 5, 2024
Merged via the queue into rust-lang:master with commit 044083c Jul 5, 2024
27 checks passed
@heiher heiher deleted the loongarch64-linux-musl branch July 5, 2024 15:06
@rami3l rami3l mentioned this pull request Oct 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants