test(manifestation): replace run_future() with TestContext
#3915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
force-pushed
the
refactor/goodbye-run-future
branch
6 times, most recently
from
8ff50ee to
cf17301
Compare
djc
reviewed
Jun 27, 2024
rami3l
force-pushed
the
refactor/goodbye-run-future
branch
from
cf17301 to
749f0c8
Compare
rami3l
changed the title
run_future() with TestContextrun_future() with TestContext
|
@djc I don't know how you'd like to proceed with your reviews, but just FYI I find this PR a perfect fit for language-aware diffs like SemanticDiff: https://app.semanticdiff.com/gh/rust-lang/rustup/pull/3915/commits |
djc
approved these changes
Jun 27, 2024
Ooohhh, that is pretty awesome. Should try to use that more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a continuation of #3367 and #3856, this PR makes all tests in
dist::manifestation::teststhat rely onrun_future()async, thus the latter can be fully removed.