Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port tests to CliTestContext #3893

Merged
merged 19 commits into from
Jun 22, 2024
Merged

Port tests to CliTestContext #3893

merged 19 commits into from
Jun 22, 2024

Conversation

djc
Copy link
Contributor

@djc djc commented Jun 18, 2024

No description provided.

@djc djc requested a review from rami3l June 18, 2024 20:57
rami3l
rami3l reviewed Jun 19, 2024
View reviewed changes
tests/suite/cli_exact.rs Outdated Show resolved Hide resolved
rami3l
rami3l approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@rami3l rami3l force-pushed the test-contexts branch 2 times, most recently from bd2ba9b to 403ef2d Compare June 20, 2024 07:30
@rami3l rami3l added this to the 1.28.0 milestone Jun 20, 2024
@djc djc force-pushed the test-contexts branch 2 times, most recently from 7504c1e to cff0cbb Compare June 22, 2024 12:51
@djc djc marked this pull request as ready for review June 22, 2024 12:58
@djc djc force-pushed the test-contexts branch from 1a86612 to ac045fe Compare June 22, 2024 13:00
djc added 17 commits June 22, 2024 15:01
@djc djc force-pushed the test-contexts branch from ac045fe to 0681adf Compare June 22, 2024 13:02
rami3l
rami3l approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the tremendous amount of work (~14 000 diffLoC)! Wouldn't be possible without you!

@djc djc force-pushed the test-contexts branch from 0681adf to a8a58ed Compare June 22, 2024 16:34
@djc djc enabled auto-merge June 22, 2024 16:34
@djc djc disabled auto-merge June 22, 2024 16:34
@djc djc force-pushed the test-contexts branch from a8a58ed to 9b38960 Compare June 22, 2024 16:36
@djc djc enabled auto-merge June 22, 2024 16:36
@djc
Copy link
Contributor Author

djc commented Jun 22, 2024

Too bad this is like +1000 lines... all from adding async in the CLI tests. Oh well...

@djc djc mentioned this pull request Jun 22, 2024
Merged
@djc djc added this pull request to the merge queue Jun 22, 2024
Merged via the queue into master with commit 78426c9 Jun 22, 2024
26 checks passed
@djc djc deleted the test-contexts branch June 22, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rami3l rami3l rami3l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djc @rami3l