Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dist): hoist dist::dist into dist #3882

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Jun 17, 2024

This is a natural step in the spirit of #3880.

Concerns

@rami3l rami3l requested a review from djc June 17, 2024 04:17
@rami3l rami3l force-pushed the refactor/no-dist-dist branch from 700b505 to e6ca90c Compare June 17, 2024 04:20
src/dist/mod.rs Show resolved Hide resolved
@djc
Copy link
Contributor

djc commented Jun 17, 2024

  • It's time to decide between foo.rs and foo/mod.rs. (I'm slightly inclined towards foo.rs, cc @rbtcollins.)

I still find this still imposes non-trivial cognitive overhead because it means each module appears twice in the directory tree, and I have to decide which one I need to open.

@rami3l
Copy link
Member Author

rami3l commented Jun 17, 2024

This is a natural step in the spirit of #3880.

Concerns

  • It's time to decide between foo.rs and foo/mod.rs. (I'm slightly inclined towards foo.rs, cc @rbtcollins.)
  • It's time to decide between foo.rs and foo/mod.rs. (I'm slightly inclined towards foo.rs, cc @rbtcollins.)

I still find this still imposes non-trivial cognitive overhead because it means each module appears twice in the directory tree, and I have to decide which one I need to open.

@djc Let's continue the discussion at #3883 since it looks not very appropriate to comment on a soon-to-be closed PR :P

@rami3l rami3l requested a review from djc June 17, 2024 06:36
@rami3l rami3l added this to the 1.28.0 milestone Jun 17, 2024
@rami3l rami3l added this pull request to the merge queue Jun 17, 2024
Merged via the queue into rust-lang:master with commit c1768a7 Jun 17, 2024
26 checks passed
@rami3l rami3l deleted the refactor/no-dist-dist branch June 17, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants