-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process cleanup #3877
Process cleanup #3877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow that's soooo impressive, friend!
Rustup is finally an "ordinary" tokio
app now thanks to your work! Hooray 🎉
Our work, couldn't have done it without you! |
@djc Let's don't forget there's one remaining concern from #3847 (comment): there are places where the original code was using rustup/src/test/mock/clitools.rs Lines 729 to 738 in 0aa7a2a
I'm not quite sure about the exact intention of those configurations, but it's better to be watchful I think. |
This is from last night. I think the custom test macros are unnecessary now, please review!