Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalise Rustup Windows Arm64 support #3840

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

Alovchin91
Copy link
Contributor

@Alovchin91 Alovchin91 commented May 23, 2024

This PR finalises Windows Arm64 support by doing the following:

The last part is the most "fragile" in my view because I don't know how the artefacts get published on rustup.rs, and detecting the arm64 CPU also required some async code that won't work in Firefox (but VS Code website’s arm64 detection doesn't work in Firefox either).

@Alovchin91 Alovchin91 force-pushed the alovchin91/win-arm64-fixes branch from 8f55949 to b94ea9a Compare May 23, 2024 17:55
www/index.html Show resolved Hide resolved
@rami3l rami3l added A-aarch64 ARM 64bit O-windows Windows related labels May 24, 2024
@rami3l rami3l added this to the 1.28.0 milestone May 24, 2024
@Alovchin91 Alovchin91 force-pushed the alovchin91/win-arm64-fixes branch from b94ea9a to 59c3820 Compare May 28, 2024 22:42
@djc
Copy link
Contributor

djc commented May 29, 2024

(This largely looks good to me, modulo one nit: would be nice to rebase away the merge commit.)

@Alovchin91 Alovchin91 force-pushed the alovchin91/win-arm64-fixes branch from 6d24cb1 to 869822d Compare May 29, 2024 08:37
@Alovchin91
Copy link
Contributor Author

(would be nice to rebase away the merge commit.)

Done! I've been rebasing for years now so I didn't realise "Update fork" button would actually create a merge commit 😅

@rami3l
Copy link
Member

rami3l commented May 29, 2024

(would be nice to rebase away the merge commit.)

Done! I've been rebasing for years now so I didn't realise "Update fork" button would actually create a merge commit 😅

@Alovchin91 You should've clicked "update with rebase". GitHub's default behavior is merging, unfortunately we cannot change it for now.

Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alovchin91 Alovchin91 force-pushed the alovchin91/win-arm64-fixes branch 2 times, most recently from d73bd19 to c4cde66 Compare June 2, 2024 00:25
@Alovchin91
Copy link
Contributor Author

Alovchin91 commented Jun 2, 2024

@rami3l Do you think it would make sense to split everything except rustup.rs website part off to a new PR that could be merged without waiting for infra? 🤔 It might already be helpful to have proper links in Other Installation Methods + the PR pipeline.

@rami3l
Copy link
Member

rami3l commented Jun 2, 2024

@rami3l Do you think it would make sense to split everything except rustup.rs website part off to a new PR that could be merged without waiting for infra? 🤔 It might already be helpful to have proper links in Other Installation Methods + the PR pipeline.

@Alovchin91 Yes, definitely. You can also use https://static.rust-lang.org/rustup/dist/aarch64-pc-windows-msvc/rustup-init.exe temporarily instead of https://win.rustup.rs/aarch64 first, then make a small PR to change that into the final URL. It's your call.

@Alovchin91
Copy link
Contributor Author

@rami3l I think I'd prefer to keep it tidy and wait for the infra ☺️ Split off into #3854

@Alovchin91 Alovchin91 force-pushed the alovchin91/win-arm64-fixes branch from c4cde66 to 094d5fc Compare June 3, 2024 00:51
@rami3l
Copy link
Member

rami3l commented Jun 3, 2024

Status: Waiting for infra's deployment of https://win.rustup.rs/aarch64. I just tested and the link seems to work without issues! Thanks a lot, @jdno!

A note to @Alovchin91: for the actual changes being made here to be in effect, we might have to wait until the next official release of Rustup. The latest version of the docs, however, can be found here. Thank you for your patience :)

@rami3l rami3l added this pull request to the merge queue Jun 5, 2024
Merged via the queue into rust-lang:master with commit 9716685 Jun 5, 2024
22 checks passed
@rami3l rami3l mentioned this pull request Oct 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-aarch64 ARM 64bit O-windows Windows related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants