-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalise Rustup Windows Arm64 support #3840
Conversation
8f55949
to
b94ea9a
Compare
b94ea9a
to
59c3820
Compare
(This largely looks good to me, modulo one nit: would be nice to rebase away the merge commit.) |
6d24cb1
to
869822d
Compare
Done! I've been rebasing for years now so I didn't realise "Update fork" button would actually create a merge commit 😅 |
@Alovchin91 You should've clicked "update with rebase". GitHub's default behavior is merging, unfortunately we cannot change it for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll ping t-infra again and let's see what we can do about https://win.rustup.rs/aarch64:
https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/.60win.2Erustup.2Ers.60.20should.20provide.20an.20.60aarch64.60.20installer
d73bd19
to
c4cde66
Compare
@rami3l Do you think it would make sense to split everything except rustup.rs website part off to a new PR that could be merged without waiting for infra? 🤔 It might already be helpful to have proper links in Other Installation Methods + the PR pipeline. |
@Alovchin91 Yes, definitely. You can also use https://static.rust-lang.org/rustup/dist/aarch64-pc-windows-msvc/rustup-init.exe temporarily instead of https://win.rustup.rs/aarch64 first, then make a small PR to change that into the final URL. It's your call. |
c4cde66
to
094d5fc
Compare
A note to @Alovchin91: for the actual changes being made here to be in effect, we might have to wait until the next official release of Rustup. The latest version of the docs, however, can be found here. Thank you for your patience :) |
This PR finalises Windows Arm64 support by doing the following:
Removes the workaround to exclude Ring on Windows Arm64. Ring 0.17.x fully supports it.Split-off into Re-enable Ring support on Windows Arm64 #3845Addsaarch64-pc-windows-msvc
download link to cloud-invalidation.txt so that this script could pick it up.Does the same foraarch64-apple-darwin
because why not?Updates the Other Installation Methods page to include Windows Arm64 version of Rustup.Split-off into Add Windows Arm64 to Other Installation Methods #3854The last part is the most "fragile" in my view because I don't know how the artefacts get published on rustup.rs, and detecting the arm64 CPU also required some async code that won't work in Firefox (but VS Code website’s arm64 detection doesn't work in Firefox either).