Omit "ETA 0s" output in download tracker #3826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
May 15, 2024
src/cli/download_tracker.rs
Outdated
Comment on lines
195
to
197
| (eta_h != Duration::ZERO) | ||
| .then(|| format!(" ETA: {}", eta_h.display())) | ||
| .unwrap_or_default() |
There was a problem hiding this comment.
I think I'd prefer to formulate it like this:
match eta_h {
Duration::ZERO => format_args!(""),
_ => format_args!(" ETA: {}", eta_h.display()),
}There was a problem hiding this comment.
hmm, that doesn't work because the format_args! creates a temporary which doesn't survive the match scope
|
That didn't exactly work, maybe bind |
|
I think format_args only works as direct argument to |
This was referenced May 15, 2024
|
Fixed in #3827. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running rustup, the ETA is shown and continuously updated. After a download has finished, ETA is 0, and it is printed for each download (marked bold)
info: downloading component 'cargo'
8.0 MiB / 8.0 MiB (100 %) 5.0 MiB/s in 1s ETA: 0s
info: downloading component 'clippy'
info: downloading component 'rust-docs'
15.1 MiB / 15.1 MiB (100 %) 5.3 MiB/s in 2s ETA: 0s
info: downloading component 'rust-std'
24.3 MiB / 24.3 MiB (100 %) 5.3 MiB/s in 4s ETA: 0s
This change omits printing the ETA when it is 0s:
info: downloading component 'cargo'
8.0 MiB / 8.0 MiB (100 %) 5.5 MiB/s in 1s
info: downloading component 'clippy'
info: downloading component 'rust-docs'
15.1 MiB / 15.1 MiB (100 %) 6.0 MiB/s in 2s
info: downloading component 'rust-std'
24.3 MiB / 24.3 MiB (100 %) 5.6 MiB/s in 4s
Not a big change :) lmk what you think :)