Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(download): use DownloadCallBack in download_with_backend() #3795

Merged
merged 1 commit into from
May 6, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Apr 27, 2024

A trivial patch cherry-picked from #3788.

@rami3l rami3l added this to the 1.28.0 milestone Apr 27, 2024
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, honestly I don't think type aliases like this are useful, so I'd prefer to just get rid of it.

@rami3l
Copy link
Member Author

rami3l commented Apr 27, 2024

Seems okay, honestly I don't think type aliases like this are useful, so I'd prefer to just get rid of it.

@djc This type was introduced to address clippy::type_complexity in #3133. I don't think it's worth it to override the lint level for this type 🤔

@rami3l rami3l added this pull request to the merge queue May 6, 2024
Merged via the queue into master with commit 381b651 May 6, 2024
22 checks passed
@rami3l rami3l deleted the refactor/download branch May 6, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants