Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix file paths in CI-generated *.sha256 files on *nix #3730

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Mar 22, 2024

Fixes #3693.

See #3693 (comment) for more context.

The sha[256]sum command on *nix relies on CWD if you use a relative path as the input arg. All file paths in its output are then relative to it.

The PowerShell script doesn't need to be fixed since there's no path in the sha256 file at all.

Concerns

  • How do I test this change? It does look quite correct though... I've tested locally. Although this is expected to print out
    f21c44b01678c645d8fbba1e55e4180a01ac5af2d38bcbd14aa665e0d96ed69a *./rustup-init
    which is not what @darthbanana13 originally asked for 1, both shasum --check rustup-init.sha256 and sha256sum --check rustup-init.sha256 do pass. I hope this result remains satisfying.

Footnotes

  1. According to https://superuser.com/a/1566139, f21c44b01678c645d8fbba1e55e4180a01ac5af2d38bcbd14aa665e0d96ed69a ./rustup-init is NOT a legal output. The file path after the separating space must start with either a indicating "text input mode", or an * indicating "binary input mode". Given this, it's quite reasonable to see an * in a sha256 file for a compiled executable.

@rami3l rami3l added this pull request to the merge queue Mar 22, 2024
Merged via the queue into master with commit 1c612cf Mar 22, 2024
21 checks passed
@rami3l rami3l deleted the ci/sha256-file-path branch March 22, 2024 10:44
@rami3l rami3l mentioned this pull request Apr 14, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checksum files for manual installation
2 participants