Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "component add" error message #3724

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fix "component add" error message #3724

merged 1 commit into from
Mar 19, 2024

Conversation

smoelius
Copy link
Contributor

Fixes #3721 (cc: @rami3l)

@rami3l
Copy link
Member

rami3l commented Mar 19, 2024 •
edited
Loading

@smoelius Thanks a lot, and don't worry about the cargo check error!

It's caused by a new beta release earlier this week. I'll send a patch to fix it, on which you'd be able to safely rebase this patch.

rami3l
rami3l approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

tests/suite/cli_misc.rs Outdated Show resolved Hide resolved
@rami3l rami3l mentioned this pull request Mar 19, 2024
Merged
1 task
@rami3l
Copy link
Member

rami3l commented Mar 19, 2024 •
edited
Loading

@smoelius Sorry for all the trouble! I've made #3725 for you which has been merged just now.

As a final step before merging, could you please

  • Rebase this PR on the latest master,
  • Use fixup to squash the 2nd commit into the 1st one?

This should fix the CI errors for you.

Thanks in advance! 🙇

@smoelius
Copy link
Contributor Author

@rami3l Sure. No problem.

@rami3l rami3l enabled auto-merge March 19, 2024 13:38
@rami3l rami3l added this pull request to the merge queue Mar 19, 2024
Merged via the queue into rust-lang:master with commit a05f8a5 Mar 19, 2024
21 checks passed
@smoelius smoelius deleted the fix-3721 branch March 19, 2024 15:43
@rami3l rami3l mentioned this pull request Apr 14, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc left review comments

@rami3l rami3l rami3l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugs in "component add" message
3 participants
@smoelius @rami3l @djc