feat: log RUSTUP_UPDATE_ROOT, RUSTUP_DIST_SERVER or RUSTUP_DIST_ROOT on RUSTUP_DEBUG
#3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
rami3l
commented
Mar 18, 2024
rami3l
commented
Mar 18, 2024
rami3l
force-pushed
the
feat/log-registry
branch
from
be73fe0
to
b50323e
Compare
rami3l
changed the title
RUSTUP_UPDATE_ROOT, RUSTUP_DIST_SERVER or RUSTUP_DIST_ROOT if setRUSTUP_UPDATE_ROOT, RUSTUP_DIST_SERVER or RUSTUP_DIST_ROOT on RUSTUP_DEBUG
rbtcollins
reviewed
Apr 14, 2024
rbtcollins
reviewed
Apr 14, 2024
rbtcollins
reviewed
Apr 14, 2024
rami3l
force-pushed
the
feat/log-registry
branch
from
18980b8
to
ab27ac4
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3680.
This PR makes log the value(s) of
RUSTUP_UPDATE_ROOT,RUSTUP_DIST_SERVERorRUSTUP_DIST_ROOTif:RUSTUP_DEBUGis set.This is a tiny yet important feature addition for our users who need to manually designate a Rustup update/dist server, either because they have to use a mirror server for acceleration, or because they need to switch to the
devenvironment for beta testing.The
RUSTUP_DEBUGpredicate minimizes both the extra noise and the required changes to the current test suite.