Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added retry flag support for curl invocations #2869

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Added retry flag support for curl invocations #2869

merged 2 commits into from
Nov 8, 2021

Conversation

facklambda
Copy link

Should fix #2853

@facklambda
Copy link
Author

My fix involves utilizing the pre-existing check_help_for function to check if --retry flag exists in the curl command's help.
If it does contain --retry, it proceeds to set --retry 3 as the curl option.
This results in 3 retries with the default exponential back-off.

kinnison
kinnison approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks reasonable, thank you for the work.

@kinnison kinnison merged commit 6244396 into rust-lang:master Nov 8, 2021
@comphead comphead mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify rustup-init.sh to support retrying the download of rustup-init
2 participants
@facklambda @kinnison