Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2748 by filling the streaming buffers fully #2750

Merged
merged 2 commits into from
May 4, 2021

Conversation

rbtcollins
Copy link
Contributor

Diagnosis by Daniel. Code by Robert.

@rbtcollins rbtcollins force-pushed the fillthebuffers branch 2 times, most recently from 79bf799 to 094e497 Compare May 4, 2021 15:13
Diagnosis by Daniel. Code by Robert.
@kinnison
Copy link
Contributor

kinnison commented May 4, 2021

If we're making this change can we also add drop(contents); before the chunk_complete_callback(len); in diskio::write_file_incremental() (mod.rs)?

@rbtcollins
Copy link
Contributor Author

If we're making this change can we also add drop(contents); before the chunk_complete_callback(len); in diskio::write_file_incremental() (mod.rs)?

Sure. Though as discussed, don't think its material.

@kinnison
Copy link
Contributor

kinnison commented May 4, 2021

Sure. Though as discussed, don't think its material.

It dropped the max-rss by not-quite-a-chunk in my basic testing

@kinnison kinnison merged commit 55ba10d into rust-lang:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants