Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report error once when got invalid toolchain name #2613

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Report error once when got invalid toolchain name #2613

merged 1 commit into from
Dec 18, 2020

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Dec 17, 2020 •
edited
Loading

Report error once when got invalid channel name.

close #2552.

@Rustin170506 Rustin170506 changed the title Report error once when got invalidate channel name Report error once when got invalid channel name Dec 17, 2020
@Rustin170506 Rustin170506 changed the title Report error once when got invalid channel name Report error once when got invalid toolchain name Dec 17, 2020
@Rustin170506
Copy link
Member Author

@kinnison Could you please take a look?

kinnison
kinnison approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you.

@kinnison kinnison merged commit 50fbbeb into rust-lang:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two lines of 'error:' when a rust-toolchain file is invalid
2 participants
@Rustin170506 @kinnison