Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

www: show whole shell command at once #2208

Merged
merged 1 commit into from
Jan 25, 2020
Merged

www: show whole shell command at once #2208

merged 1 commit into from
Jan 25, 2020

Conversation

harrysarson
Copy link
Contributor

@harrysarson harrysarson commented Jan 21, 2020 •
edited
Loading

Makes the width of the shell box slightly larger and the font size slightly smaler.

Fixes: #2207

Before:
image

After:
image

cc: @birkenfeld

@birkenfeld
Copy link

For me, looks like this:

image

So a bit more generous, and we're good :)

harrysarson
harrysarson commented Jan 21, 2020
View reviewed changes
Copy link
Contributor Author

@harrysarson harrysarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it look now?

www/rustup.css Outdated Show resolved Hide resolved
www/rustup.css Outdated Show resolved Hide resolved
www/rustup.css Outdated Show resolved Hide resolved
@harrysarson
www: show whole shell command at once
968329d 
Makes the width of the shell box slightly larger and the font size slightly smaler.

Fixes: rust-lang#2207
@harrysarson
Copy link
Contributor Author

@brikenfeld have you had a chance to have a look?

@birkenfeld
Copy link

LGTM now, thanks!

kinnison
kinnison approved these changes Jan 25, 2020
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason not to accept this. Website updates happen on releases of rustup normally so you won't see any updates until the release of 1.22.0 but then it should be done. Thank you all for your efforts cleaning this up.

@kinnison kinnison merged commit dd8dbf3 into rust-lang:master Jan 25, 2020
@harrysarson harrysarson deleted the show-shell branch January 25, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: show whole shell command at once
3 participants
@harrysarson @birkenfeld @kinnison