Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinnison/fix progress on windows #1788

Merged
merged 2 commits into from
Apr 22, 2019

Conversation

kinnison
Copy link
Contributor

Following on from testing the 1.18.0 RC on Windows, this is needed to fix line erase

In rust-lang#1781, we switched to using `delete_line()` but unfortunately
that turns out to not work very well on Windows.  So this commit
turns us back to using spaces to erase things, but in a way which
ought to be moderately more robust than before.  There's still
no guarantee we're doing it right, but at least this time if
the terminal is approximately wide enough for the bar and no more,
we won't be flowing onto the next line with loads of spaces after
the rest of the tracker.

Signed-off-by: Daniel Silverstone <[email protected]>
The amended erase was insufficient, this revert of term to 0.5.1 was
also required otherwise the end-of-line was oddly miscoloured.

Signed-off-by: Daniel Silverstone <[email protected]>
@Skynoodle
Copy link

Tested and working on Windows 10 with both Powershell and CMD.
Looks fine to me 👍

@kinnison
Copy link
Contributor Author

Awesome, thank you @Skynoodle

@kinnison kinnison merged commit a3907d6 into rust-lang:stable Apr 22, 2019
@kinnison kinnison deleted the kinnison/fix-progress-on-windows branch April 22, 2019 20:42
@tesuji tesuji mentioned this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants