-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors: Reorder component-unavailable message parts #1769
errors: Reorder component-unavailable message parts #1769
Conversation
a60c989
to
ecd8b59
Compare
"If you require" (capitalized)?
"for example:" (colon)? Or is it not about the command line, but about URL to look for build status? Then there should be some other introductory sentence before the command line sample, such as |
Fair, I'll get that message updated later. Is this the only problem you have with the result? |
Probably yes, although I'd also specified explicitly that it would not be the
The system (tracking nightly which points to some date, plus explicit dated nightlies) is in general a bit confusing, so longer help messages won't hurt. |
The ordering of some of the parts of the component-unavailable error message was unfortunate, resulting in confusion. This reorders those so that errors are slightly clearer. In addition we reword the explanatory text slightly to improve clarity further Fixes: rust-lang#1768 Signed-off-by: Daniel Silverstone <[email protected]>
ecd8b59
to
928e768
Compare
Explanatory message updated to:
|
Looks OK. If #1628 is implemented some way (e.g. |
Thanks @vi |
The ordering of some of the parts of the component-unavailable
error message was unfortunate, resulting in confusion. This
reorders those so that errors are slightly clearer.
Fixes: #1768
As an example, the old message form would be:
The new form is:
/cc @vi