Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: Reorder component-unavailable message parts #1769

Merged

Conversation

kinnison
Copy link
Contributor

The ordering of some of the parts of the component-unavailable
error message was unfortunate, resulting in confusion. This
reorders those so that errors are slightly clearer.

Fixes: #1768

As an example, the old message form would be:

error: some components unavailable for download: 'rls', 'clippy'
if you require these components, please install and use the latest successful build version, which you can find at https://rust-lang-nursery.github.io/rust-toolstate, for example.
rustup install nightly-2018-12-27 for channel 'nightly'

The new form is:

error: some components unavailable for download: 'rls', 'clippy' for channel 'nightly'
if you require these components, please install and use the latest successful build version, which you can find at https://rust-lang-nursery.github.io/rust-toolstate, for example.
rustup install nightly-2018-12-27

/cc @vi

@kinnison kinnison force-pushed the kinnison/better-error-no-toolchain branch from a60c989 to ecd8b59 Compare April 15, 2019 18:10
@kinnison kinnison added this to the 1.18.0 milestone Apr 15, 2019
@vi
Copy link

vi commented Apr 15, 2019

if you require

"If you require" (capitalized)?

for example.

"for example:" (colon)? Or is it not about the command line, but about URL to look for build status? Then there should be some other introductory sentence before the command line sample, such as after determining the required date, use command line like this:.

@kinnison
Copy link
Contributor Author

Fair, I'll get that message updated later. Is this the only problem you have with the result?

@vi
Copy link

vi commented Apr 16, 2019

Probably yes, although I'd also specified explicitly that it would not be the nightly toolchain.

After determining the date, install it with a command like this:

    rustup install nightly-2018-12-27

Then use it as a toolchain name:

    cargo +nightly-2018-12-27 build

The system (tracking nightly which points to some date, plus explicit dated nightlies) is in general a bit confusing, so longer help messages won't hurt.

The ordering of some of the parts of the component-unavailable
error message was unfortunate, resulting in confusion.  This
reorders those so that errors are slightly clearer.  In addition
we reword the explanatory text slightly to improve clarity further

Fixes: rust-lang#1768

Signed-off-by: Daniel Silverstone <[email protected]>
@kinnison kinnison force-pushed the kinnison/better-error-no-toolchain branch from ecd8b59 to 928e768 Compare April 16, 2019 10:53
@kinnison
Copy link
Contributor Author

Explanatory message updated to:

If you require these components, please install and use the latest successful build version,
which you can find at https://rust-lang-nursery.github.io/rust-toolstate.

After determining the correct date, install it with a command such as:

    rustup toolchain install nightly-2018-12-27

Then you can use the toolchain with commands such as:

    cargo +nightly-2018-12-27 build

@vi
Copy link

vi commented Apr 16, 2019

Looks OK.

If #1628 is implemented some way (e.g. --override-nightly-date option for rustup update nightly), then this message should be updated.

@kinnison
Copy link
Contributor Author

Thanks @vi

@kinnison kinnison merged commit af4d475 into rust-lang:master Apr 16, 2019
@kinnison kinnison deleted the kinnison/better-error-no-toolchain branch April 16, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message about missing nightly components suggests using invalid command
2 participants