Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG from 1.14 upto 1.17 #1689

Merged
merged 6 commits into from
Mar 7, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Mar 7, 2019

Fixes #1686.

@tesuji
Copy link
Contributor Author

tesuji commented Mar 7, 2019

r? @kinnison

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. @dwijnand ?

@lzutao - Did you create the content using a script, and if so, is it worth adding it, either to the repo or at least as a section in the CONTRIBUTING document?

Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dwijnand dwijnand merged commit 5bdc803 into rust-lang:master Mar 7, 2019
@tesuji tesuji deleted the keepachangelog branch March 7, 2019 11:50
@tesuji
Copy link
Contributor Author

tesuji commented Mar 7, 2019

@kinnison No, I didn't use automatic script to generate CHANGELOG.

I did the following steps to manually update CHANGELOG:

  • Make sure your local repository updated and had tags synced with remote:

    git checkout master && git pull --tags

  • Write new tag and tag's date in format:

    # [1.16.0] - 2018-12-06

    Date format is ISO-8601. Old tag date could be gotten by: git show -s --format=%ci <tag>.

  • Checkout what's changed between old tag and new commit/tag:

    git log --stat --graph 1.16.0...<commit/tag>

    or use GitHub interface: 1.16.0...master

  • Filter out commits meet these conditions:

    • Typo fix
    • Small CI fix
  • List all other changes in CHANGELOG:

    * [Pull request name/Main content of the change](Link to pull request)

If having time, I could write an automatic script to generate CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants