Preserve symlinks when installing #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lldb-preview component includes symlinks. Currently, rustup changes these to be regular files while installing. This then causes the resulting lldb to load liblldb twice, which causes a crash at startup, because command line options are registered twice. This changes rustup to preserve symlinks when installing.
|
I wasn't sure if I should base this on stable perhaps? |
|
@nrc would you mind reviewing this or forwarding it to someone else to review? Fixing this is the next (hopefully final) step in getting lldb to work via rustup. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lldb-preview component includes symlinks. Currently, rustup
changes these to be regular files while installing. This then causes
the resulting lldb to load liblldb twice, which causes a crash at
startup, because command line options are registered twice. This
changes rustup to preserve symlinks when installing.