Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use command in BROWSER env if present for doc command #1289

Merged
merged 2 commits into from
May 27, 2018

Conversation

naufraghi
Copy link
Contributor

If the BROWSER enviroment variable is found, it is used as a list of
commands to be tested before the hardcoded ones to launch a browser.

Issue #1287

If the BROWSER enviroment variable is found, it is used as a list of
commands to be tested before the hardcoded ones to launch a browser.

Issue rust-lang#1287
@naufraghi naufraghi changed the title Use browser in BROWSER env if present for doc command Use command in BROWSER env if present for doc command Nov 7, 2017
@bors
Copy link
Contributor

bors commented Apr 13, 2018

☔ The latest upstream changes (presumably #1390) made this pull request unmergeable. Please resolve the merge conflicts.

@Diggsey
Copy link
Contributor

Diggsey commented May 27, 2018

Thanks for the PR!

@Diggsey Diggsey merged commit 793aac3 into rust-lang:master May 27, 2018
@MihirLuthra
Copy link

MihirLuthra commented Jun 6, 2020

@naufraghi, how exactly could I utilize this feature? I tried export BROWSER=firefox and then rustup doc std::iter::Iterator but it still opens up in my default browser which is safari.

@kinnison
Copy link
Contributor

kinnison commented Jun 6, 2020

We now use opener not this change, as such you should look at how the XDG standard expects you to configure things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants