Rustup-Init displays ETA with lots of decimal places #1696
Labels
Comments
|
Interesting, I thought we'd merged some code to improve matters here. Thank you for this report. |
|
@Manishearth Could this be related to the work you did for #1547 ? |
|
Yeah some of the things there need to be casted to integers. I'll make a patch. |
Manishearth
added a commit
to Manishearth/rustup.rs
that referenced
this issue
Mar 9, 2019
Manishearth
added a commit
to Manishearth/rustup.rs
that referenced
this issue
Mar 9, 2019
tesuji
pushed a commit
to tesuji/rustup
that referenced
this issue
Apr 21, 2019
The workaround here that was printing many spaces did not work properly if the line length got very long and then very short again. I noticed this problem on an old version of rustup that still suffered from rust-lang#1696, so it might not technically be reproducible anymore, but I figured we might as well fix this for the future anyway! I suspect the comment saying `delete_line()` didn't clear the line properly was attempting to call it *after* printing the current download progress, but the `term` crate docs say it deletes from the cursor position to the end of the line. To deal with that, we instead jump to the start of the line *before* printing the current download progress and call `delete_line()` there.
tesuji
pushed a commit
to tesuji/rustup
that referenced
this issue
Apr 21, 2019
The workaround here that was printing many spaces did not work properly if the line length got very long and then very short again. I noticed this problem on an old version of rustup that still suffered from rust-lang#1696, so it might not technically be reproducible anymore, but I figured we might as well fix this for the future anyway! I suspect the comment saying `delete_line()` didn't clear the line properly was attempting to call it *after* printing the current download progress, but the `term` crate docs say it deletes from the cursor position to the end of the line. To deal with that, we instead jump to the start of the line *before* printing the current download progress and call `delete_line()` there.
tesuji
pushed a commit
to tesuji/rustup
that referenced
this issue
Apr 21, 2019
The workaround here that was printing many spaces did not work properly if the line length got very long and then very short again. I noticed this problem on an old version of rustup that still suffered from rust-lang#1696, so it might not technically be reproducible anymore, but I figured we might as well fix this for the future anyway! I suspect the comment saying `delete_line()` didn't clear the line properly was attempting to call it *after* printing the current download progress, but the `term` crate docs say it deletes from the cursor position to the end of the line. To deal with that, we instead jump to the start of the line *before* printing the current download progress and call `delete_line()` there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
I installed Rust 1.33 using Rustup-Init.exe on Windows 10 (in a Powershell window), and the ETA while installing displayed many decimal places that can be seen below. (See the last line of the picture).
Steps
Notes
Output of
rustup-init --version: rustup-init 1.17.0 (069c88e 2019-03-05)The text was updated successfully, but these errors were encountered: