-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'show' when active toolchain is not installed #1178
Comments
Fix up test cases in tests/cli-rustup.rs |
Here is thrown the error: I don't know how to extract required data from it but it someone wants to fix it this tip may help. |
I managed to get about 50% done this yesterday evening. I will be able to finish it over the next five days if nobody needs it sooner. |
… is not installed. Fixes rust-lang#1178
… is not installed. Fixes rust-lang#1178
…ed, r=alexcrichton Fix 'show' so it displays helpful information if the active toolchain is not installed. Fixed 'show' so that it displays helpful information if the active toolchain is not installed. ``` $ export RUSTUP_TOOLCHAIN=beta $ rustup show Default host: x86_64-unknown-linux-gnu installed toolchains -------------------- stable-x86_64-unknown-linux-gnu nightly-x86_64-unknown-linux-gnu active toolchain ---------------- (error: override toolchain 'beta' is not installed, the RUSTUP_TOOLCHAIN environment variable specifies an uninstalled toolchain) ``` Fixes #1178
… is not installed. Fixes rust-lang#1178
Here's what happens when you run 'show' with a toolchain that is not installed:
Instead of displaying various information about installed toolchains it immediately errors.
It should instead do something like:
Fix will be in
rustup_cli::rustup_mode::show
. Instead of returning the error, print it into the show output.The text was updated successfully, but these errors were encountered: