Skip to content

Commit

Permalink
Auto merge of #1255 - silverjam:silverjam/improve-add-req-component-e…
Browse files Browse the repository at this point in the history
…rror, r=alexcrichton

Improve clarity of "adding req. component" error

Fixes #1251.
  • Loading branch information
bors committed Sep 21, 2017
2 parents 861eac9 + 13792a5 commit 80f9ec7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/rustup/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ error_chain! {
}
AddingRequiredComponent(t: String, c: Component) {
description("required component cannot be added")
display("component {} is required for toolchain '{}' and cannot be re-added",
display("component {} was automatically added because it is required for toolchain '{}'",
c.description(), t)
}
ParsingSettings(e: Vec<toml::ParserError>) {
Expand Down
2 changes: 1 addition & 1 deletion tests/cli-v2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ fn add_target_host() {
let trip = TargetTriple::from_build();
expect_ok(config, &["rustup", "default", "nightly"]);
expect_err(config, &["rustup", "target", "add", &trip.to_string()],
for_host!("component 'rust-std' for target '{0}' is required for toolchain 'nightly-{0}' and cannot be re-added"));
for_host!("component 'rust-std' for target '{0}' was automatically added because it is required for toolchain 'nightly-{0}'"));
});
}

Expand Down

0 comments on commit 80f9ec7

Please sign in to comment.