Fix inconsistent wording #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second test expects the function to return 80 when there is an order of 40 apples, but the current wording implies returning 40 will pass as well
|
Nice catch! |
suryapandian
approved these changes
Aug 22, 2021
|
@all-contributors please add @dbednar230 for content |
|
@diannasoriel I've put up a pull request to add @dbednar230! 🎉 |
I am sorry @diannasoriel and @dbednar230 Thank you @Mark-S-Hill for pointing this out. |
|
@suryapandian you're right 🙈 I'll revert it |
I will be more careful looking at PRs going forward :) |
bugaolengdeyuxiaoer
pushed a commit
to bugaolengdeyuxiaoer/rustlings
that referenced
this pull request
Dec 28, 2021
The second test expects the function to return 80 when there is an order of 40 apples, but the current wording implies returning 40 will pass as well
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
The second test expects the function to return 80 when there is an order of 40 apples, but the current wording implies returning 40 will pass as well
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
The second test expects the function to return 80 when there is an order of 40 apples, but the current wording implies returning 40 will pass as well
Spacebody
pushed a commit
to Spacebody/my-rustlings
that referenced
this pull request
Nov 18, 2022
The second test expects the function to return 80 when there is an order of 40 apples, but the current wording implies returning 40 will pass as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second test expects the function to return 80 when there is an order of 40 apples, but the current wording implies returning 40 will pass as well