Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules exercise #822

Merged
merged 7 commits into from
Sep 3, 2021

Conversation

anuk909
Copy link
Contributor

@anuk909 anuk909 commented Aug 13, 2021

I updated the module exercises a little bit and changed the book dependency to be all chapter 7 and not only 7.2.

I'm new to rust and I'm learning by reading the book and exercise with rustlings. Yesterday I reached the modules exercise and it was very shallow compared to what they show in the book and 7.2 just isn't enough to answer the exercise (and chapter 7 of the book is very good by the way). Improving the module exercise could be very nice to future learners because it's important part of rust.

exercises/modules/modules1.rs Outdated Show resolved Hide resolved
exercises/modules/modules1.rs Outdated Show resolved Hide resolved
exercises/modules/modules2.rs Outdated Show resolved Hide resolved
exercises/modules/modules2.rs Show resolved Hide resolved
exercises/modules/modules3.rs Outdated Show resolved Hide resolved
exercises/modules/modules3.rs Outdated Show resolved Hide resolved
info.toml Outdated Show resolved Hide resolved
info.toml Outdated Show resolved Hide resolved
@anuk909
Copy link
Contributor Author

anuk909 commented Aug 26, 2021

@diannasoriel Fixed all review comments

@shadows-withal shadows-withal merged commit dfd2fab into rust-lang:main Sep 3, 2021
@shadows-withal
Copy link
Member

@all-contributors please add @anuk909 for content and code

@allcontributors
Copy link
Contributor

@diannasoriel

I've put up a pull request to add @anuk909! 🎉

@anuk909 anuk909 deleted the update_modules_exercise branch September 3, 2021 09:30
bugaolengdeyuxiaoer pushed a commit to bugaolengdeyuxiaoer/rustlings that referenced this pull request Dec 28, 2021
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
Spacebody pushed a commit to Spacebody/my-rustlings that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants