Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add detail to arc1.rs comment and hint message #710

Merged
merged 5 commits into from
Apr 21, 2021

Conversation

bmacer
Copy link
Contributor

@bmacer bmacer commented Apr 20, 2021

Adds an explanation to exercises/standard_library_types/arc1.rs to hopefully alleviate some confusion around this exercise. Hopefully sufficient to close #250.

Copy link
Member

@shadows-withal shadows-withal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I think this is a great step in the right direction :) I added some stylistic pointers, and I'll have someone else look over it before we merge it, but this looks really good to me.

exercises/standard_library_types/arc1.rs Outdated Show resolved Hide resolved
exercises/standard_library_types/arc1.rs Outdated Show resolved Hide resolved
exercises/standard_library_types/arc1.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jrvidal jrvidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor nit

exercises/standard_library_types/arc1.rs Outdated Show resolved Hide resolved
@shadows-withal shadows-withal merged commit 81be404 into rust-lang:main Apr 21, 2021
@shadows-withal
Copy link
Member

@all-contributors please add @bmacer for content

@allcontributors
Copy link
Contributor

@fmoko

I've put up a pull request to add @bmacer! 🎉

ingrachen pushed a commit to ingrachen/rustlings that referenced this pull request May 2, 2021
wh5a pushed a commit to wh5a/rustlings-solutions that referenced this pull request May 4, 2021
* upstream/main: (38 commits)
  docs: update .all-contributorsrc [skip ci]
  docs: update README.md [skip ci]
  style(standard_library_types): stray line break
  chore: Update quiz1.rs add explicit test for 40
  docs: update .all-contributorsrc [skip ci]
  docs: update README.md [skip ci]
  updated README.md; specify need for admin rights
  release: 4.4.0
  chore(watch): add hint for the exercises README.md
  chore(deps): update cargo dependencies
  docs(exercises): updated all exercises readme files
  docs(generics): add bounds help
  docs(errors): add additional help for Result/Boxing
  fix(main): Let find_exercise work with borrows
  docs: update .all-contributorsrc [skip ci]
  docs: update README.md [skip ci]
  feat(arc1): Add more details to description and hint (rust-lang#710)
  chore: Fix integration tests
  feat: Replace clap with argh
  Improved iterators5.rs explanation.
  ...
liangminhua pushed a commit to liangminhua/rustlings that referenced this pull request Jul 10, 2021
noiffion pushed a commit to noiffion/rustlings that referenced this pull request Aug 20, 2021
bugaolengdeyuxiaoer pushed a commit to bugaolengdeyuxiaoer/rustlings that referenced this pull request Dec 28, 2021
Co-authored-by: bmacer <[email protected]>
Co-authored-by: marisa <[email protected]>
Co-authored-by: Roberto Vidal <[email protected]>
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
Co-authored-by: bmacer <[email protected]>
Co-authored-by: marisa <[email protected]>
Co-authored-by: Roberto Vidal <[email protected]>
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
Co-authored-by: bmacer <[email protected]>
Co-authored-by: marisa <[email protected]>
Co-authored-by: Roberto Vidal <[email protected]>
Spacebody pushed a commit to Spacebody/my-rustlings that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arc1 seems like a giant step
3 participants