-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add detail to arc1.rs comment and hint message #710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! I think this is a great step in the right direction :) I added some stylistic pointers, and I'll have someone else look over it before we merge it, but this looks really good to me.
Co-authored-by: marisa <[email protected]>
Co-authored-by: marisa <[email protected]>
Co-authored-by: marisa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor nit
Co-authored-by: Roberto Vidal <[email protected]>
@all-contributors please add @bmacer for content |
@fmoko I've put up a pull request to add @bmacer! 🎉 |
Co-authored-by: bmacer <[email protected]> Co-authored-by: marisa <[email protected]> Co-authored-by: Roberto Vidal <[email protected]>
* upstream/main: (38 commits) docs: update .all-contributorsrc [skip ci] docs: update README.md [skip ci] style(standard_library_types): stray line break chore: Update quiz1.rs add explicit test for 40 docs: update .all-contributorsrc [skip ci] docs: update README.md [skip ci] updated README.md; specify need for admin rights release: 4.4.0 chore(watch): add hint for the exercises README.md chore(deps): update cargo dependencies docs(exercises): updated all exercises readme files docs(generics): add bounds help docs(errors): add additional help for Result/Boxing fix(main): Let find_exercise work with borrows docs: update .all-contributorsrc [skip ci] docs: update README.md [skip ci] feat(arc1): Add more details to description and hint (rust-lang#710) chore: Fix integration tests feat: Replace clap with argh Improved iterators5.rs explanation. ...
Co-authored-by: bmacer <[email protected]> Co-authored-by: marisa <[email protected]> Co-authored-by: Roberto Vidal <[email protected]>
Co-authored-by: bmacer <[email protected]> Co-authored-by: marisa <[email protected]> Co-authored-by: Roberto Vidal <[email protected]>
Co-authored-by: bmacer <[email protected]> Co-authored-by: marisa <[email protected]> Co-authored-by: Roberto Vidal <[email protected]>
Co-authored-by: bmacer <[email protected]> Co-authored-by: marisa <[email protected]> Co-authored-by: Roberto Vidal <[email protected]>
Co-authored-by: bmacer <[email protected]> Co-authored-by: marisa <[email protected]> Co-authored-by: Roberto Vidal <[email protected]>
Co-authored-by: bmacer <[email protected]> Co-authored-by: marisa <[email protected]> Co-authored-by: Roberto Vidal <[email protected]>
Adds an explanation to exercises/standard_library_types/arc1.rs to hopefully alleviate some confusion around this exercise. Hopefully sufficient to close #250.