Fix incorrect hashmap2 test #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test description says "at least five types of fruit", but the test itself is checking for exactly five types of fruit, which was a bit misleading for newcomers like me :) A simple change from "==" to ">=" should do the trick and successfully check for the "at least" condition.
pete-eiger
changed the title
AbdouSeck
approved these changes
Apr 13, 2021
shadows-withal
approved these changes
Apr 20, 2021
|
@all-contributors please add @arthas168 for content |
|
@fmoko I've put up a pull request to add @arthas168! 🎉 |
ingrachen
pushed a commit
to ingrachen/rustlings
that referenced
this pull request
May 2, 2021
The test description says "at least five types of fruit", but the test itself is checking for exactly five types of fruit, which was a bit misleading for newcomers like me :) A simple change from "==" to ">=" should do the trick and successfully check for the "at least" condition.
liangminhua
pushed a commit
to liangminhua/rustlings
that referenced
this pull request
Jul 10, 2021
The test description says "at least five types of fruit", but the test itself is checking for exactly five types of fruit, which was a bit misleading for newcomers like me :) A simple change from "==" to ">=" should do the trick and successfully check for the "at least" condition.
noiffion
pushed a commit
to noiffion/rustlings
that referenced
this pull request
Aug 20, 2021
The test description says "at least five types of fruit", but the test itself is checking for exactly five types of fruit, which was a bit misleading for newcomers like me :) A simple change from "==" to ">=" should do the trick and successfully check for the "at least" condition.
bugaolengdeyuxiaoer
pushed a commit
to bugaolengdeyuxiaoer/rustlings
that referenced
this pull request
Dec 28, 2021
The test description says "at least five types of fruit", but the test itself is checking for exactly five types of fruit, which was a bit misleading for newcomers like me :) A simple change from "==" to ">=" should do the trick and successfully check for the "at least" condition.
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
The test description says "at least five types of fruit", but the test itself is checking for exactly five types of fruit, which was a bit misleading for newcomers like me :) A simple change from "==" to ">=" should do the trick and successfully check for the "at least" condition.
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
The test description says "at least five types of fruit", but the test itself is checking for exactly five types of fruit, which was a bit misleading for newcomers like me :) A simple change from "==" to ">=" should do the trick and successfully check for the "at least" condition.
Spacebody
pushed a commit
to Spacebody/my-rustlings
that referenced
this pull request
Nov 18, 2022
The test description says "at least five types of fruit", but the test itself is checking for exactly five types of fruit, which was a bit misleading for newcomers like me :) A simple change from "==" to ">=" should do the trick and successfully check for the "at least" condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
at_least_five_types_of_fruitsimplies that there should beat leastfive types of fruit in the basket, but the test is actually checking forexactlyfive types of fruit, which was a bit misleading for newcomers like me :)A simple change from
==to>=should do the trick and properly check for theat least 5condition.