-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(primitive_types6): Add a test #548
feat(primitive_types6): Add a test #548
Conversation
e0271e0
to
2919fde
Compare
Did a force push to problem description and rewrite |
Co-authored-by: Annika <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@all-contributors please add @darnuria for code |
@fmoko I've put up a pull request to add @darnuria! 🎉 |
@all-contributors please add @AnnikaCodes for review |
@fmoko I've put up a pull request to add @AnnikaCodes! 🎉 |
let's try this again without conflicts @all-contributors please add @AnnikaCodes for review |
@fmoko I've put up a pull request to add @AnnikaCodes! 🎉 |
@all-contributors please add @AnnikaCodes for review |
@fmoko I've put up a pull request to add @AnnikaCodes! 🎉 |
Co-authored-by: Annika <[email protected]> Co-authored-by: fmoko <[email protected]>
Co-authored-by: Annika <[email protected]> Co-authored-by: fmoko <[email protected]>
Co-authored-by: Annika <[email protected]> Co-authored-by: fmoko <[email protected]>
Co-authored-by: Annika <[email protected]> Co-authored-by: fmoko <[email protected]>
Co-authored-by: Annika <[email protected]> Co-authored-by: fmoko <[email protected]>
Co-authored-by: Annika <[email protected]> Co-authored-by: fmoko <[email protected]>
To keep constancy with
primitive_types4.rs
I suggest to add a test inprimitive_types6.rs
this suggestion comes from my students because some students were just typing any numbers.Also added a little indication in order to avoid passing solution with just typing the number. Also it's possible to type out
numbers.???
to avoid this possible unexpected outcome I got it in class this week.If it's not an issue or if this not merge-able in this state I am open to discussion! :)