Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(primitive_types6): Add a test #548

Merged
merged 3 commits into from
Oct 10, 2020

Conversation

darnuria
Copy link
Contributor

@darnuria darnuria commented Oct 4, 2020

To keep constancy with primitive_types4.rs I suggest to add a test in primitive_types6.rs this suggestion comes from my students because some students were just typing any numbers.

Also added a little indication in order to avoid passing solution with just typing the number. Also it's possible to type out numbers.??? to avoid this possible unexpected outcome I got it in class this week.

If it's not an issue or if this not merge-able in this state I am open to discussion! :)

@darnuria
Copy link
Contributor Author

darnuria commented Oct 4, 2020

Did a force push to problem description and rewrite syntax instead of syntaxe (french way to write the same word). ;)

Copy link
Member

@shadows-withal shadows-withal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shadows-withal shadows-withal changed the title Add a test in primitive_types6.rs feat(primitive_types6): Add a test Oct 10, 2020
@shadows-withal shadows-withal merged commit 2b1fb2b into rust-lang:main Oct 10, 2020
@shadows-withal
Copy link
Member

@all-contributors please add @darnuria for code

@allcontributors
Copy link
Contributor

@fmoko

I've put up a pull request to add @darnuria! 🎉

@darnuria darnuria deleted the primitive_types6/test branch October 10, 2020 14:06
@shadows-withal
Copy link
Member

@all-contributors please add @AnnikaCodes for review

@allcontributors
Copy link
Contributor

@fmoko

I've put up a pull request to add @AnnikaCodes! 🎉

@shadows-withal
Copy link
Member

let's try this again without conflicts

@all-contributors please add @AnnikaCodes for review

@allcontributors
Copy link
Contributor

@fmoko

I've put up a pull request to add @AnnikaCodes! 🎉

@shadows-withal
Copy link
Member

@all-contributors please add @AnnikaCodes for review

@allcontributors
Copy link
Contributor

@fmoko

I've put up a pull request to add @AnnikaCodes! 🎉

mccormickt pushed a commit to mccormickt/rustlings that referenced this pull request Mar 10, 2021
noiffion pushed a commit to noiffion/rustlings that referenced this pull request Aug 20, 2021
bugaolengdeyuxiaoer pushed a commit to bugaolengdeyuxiaoer/rustlings that referenced this pull request Dec 28, 2021
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
Spacebody pushed a commit to Spacebody/my-rustlings that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants